Cleanup load average handling#21037
Merged
jasontedor merged 1 commit intoelastic:masterfrom Oct 20, 2016
jasontedor:load-average-cleanup
Merged
Cleanup load average handling#21037jasontedor merged 1 commit intoelastic:masterfrom jasontedor:load-average-cleanup
jasontedor merged 1 commit intoelastic:masterfrom
jasontedor:load-average-cleanup
Conversation
This commit cleans up the code handling load averages in OsProbe: - remove support for BSD; we do not support this OS - add Javadocs - strengthen assertions and testing - add debug logging for exceptional situation
nik9000
approved these changes
Oct 20, 2016
| } | ||
|
|
||
| public void testGetSystemLoadAverage() { | ||
| assumeTrue("test runs on Linux only", Constants.LINUX); |
Member
There was a problem hiding this comment.
You could probably avoid this by making the linux check a method that you stub out in OsProbe.
Member
Author
There was a problem hiding this comment.
I thought about that, but there's more to it because the getSystemLoadAverage method starts with if (Constants.WINDOWS) so then that has to stubbed out too, and then it's just not worth it? We have sufficient coverage on Linux with the CI.
jasontedor
added a commit
that referenced
this pull request
Oct 20, 2016
This commit cleans up the code handling load averages in OsProbe: - remove support for BSD; we do not support this OS - add Javadocs - strengthen assertions and testing - add debug logging for exceptional situation Relates #21037
Member
Author
|
Thanks @nik9000. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit cleans up the code handling load averages in OsProbe: