Merged
Conversation
nik9000
approved these changes
Oct 11, 2016
Member
|
Do you think we can write a checkstyle or forbidden patterns test to fail the build on these? |
Member
Author
Thanks @nik9000 - I'll have a look if this is feasible. |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 21, 2016
This commit adds a RegexpMultiline check to checkstyle that yells when an empty Javadoc comment is found in Java files. Related elastic#20871
tlrx
added a commit
that referenced
this pull request
Nov 21, 2016
This commit adds a RegexpMultiline check to checkstyle that yells when an empty Javadoc comment is found in Java files. Related #20871
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because I'm tired to see those empty javadoc comments every day.