Process more expensive allocation deciders last#20724
Merged
abeyad merged 2 commits intoelastic:masterfrom Oct 4, 2016
Merged
Conversation
order when initialized in AllocationDeciders, which means potentially more performance intensive allocation deciders could run before less expensive deciders. This adds to the execution time when a less expensive decider could terminate the decision making process early with a NO decision. This commit orders the initialization of allocation deciders, based on a general assessment of the big O runtime of each decider, moving the likely more expensive deciders last. Closes elastic#12815
bleskes
approved these changes
Oct 4, 2016
| addAllocationDecider(deciders, new ThrottlingAllocationDecider(settings, clusterSettings)); | ||
| addAllocationDecider(deciders, new ShardsLimitAllocationDecider(settings, clusterSettings)); | ||
| addAllocationDecider(deciders, new AwarenessAllocationDecider(settings, clusterSettings)); | ||
| addAllocationDecider(deciders, new FilterAllocationDecider(settings, clusterSettings)); |
Contributor
There was a problem hiding this comment.
I think this one is fairly lite - typically there only a few and very specific rules
Author
There was a problem hiding this comment.
@bleskes I agree if there are just a small number of filter rules, then this one should be lighter than the others. I'll move it up and push.
Author
|
thanks for the review @bleskes |
abeyad
pushed a commit
that referenced
this pull request
Oct 4, 2016
Today, the individual allocation deciders appear in random order when initialized in AllocationDeciders, which means potentially more performance intensive allocation deciders could run before less expensive deciders. This adds to the execution time when a less expensive decider could terminate the decision making process early with a NO decision. This commit orders the initialization of allocation deciders, based on a general assessment of the big O runtime of each decider, moving the likely more expensive deciders last. Closes #12815
Author
|
5.x commit: 2fae528 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, the individual allocation deciders appear in random
order when initialized in AllocationDeciders, which means
potentially more performance intensive allocation deciders
could run before less expensive deciders. This adds to the
execution time when a less expensive decider could terminate
the decision making process early with a NO decision. This
commit orders the initialization of allocation deciders,
based on a general assessment of the big O runtime of each
decider, moving the likely more expensive deciders last.
This manner of assessing the decider performance time is a
best guess and meant for a quick win in terms of performance
benefit.
Closes #12815