Fixes active shard count check in the case of all shards#19760
Merged
abeyad merged 1 commit intoelastic:masterfrom Aug 2, 2016
Merged
Fixes active shard count check in the case of all shards#19760abeyad merged 1 commit intoelastic:masterfrom
all shards#19760abeyad merged 1 commit intoelastic:masterfrom
Conversation
Member
There was a problem hiding this comment.
Perhaps add a comment to explain why the +1? (because of the primary I assume, but it's still nice to be explicit for newcomers to the codebase)
Member
|
LGTM, left one comment, no need to re-review |
Author
|
@dakrone thanks for the review! |
ActiveShardCount.ALL by checking for active shards, not just started shards, as a shard could be active but in the relocating state (i.e. not in the started state).
e4846f4 to
082bb5d
Compare
jasontedor
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Aug 3, 2016
* master: Fix REST test documentation [Test] move methods from bwc test to test package for use in plugins (elastic#19738) package-info.java should be in src/main only. Split regular histograms from date histograms. elastic#19551 Tighten up concurrent store metadata listing and engine writes (elastic#19684) Plugins: Make NamedWriteableRegistry immutable and add extenion point for named writeables Add documentation for the 'elasticsearch-translog' tool [TEST] Increase time waiting for all shards to move off/on to a node Fixes the active shard count check in the case of (elastic#19760) Fixes cat tasks operation in detailed mode ignore some docker craziness in scccomp environment checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the active shard count check in the case of
ActiveShardCount.ALL by checking for active shards,
not just started shards, as a shard could be active
but in the relocating state (i.e. not in the started
state).
Previously, the
ReplicationOperationTests#testWaitForActiveShardsfailed with the following reproduce:It no longer fails with this PR