Increase timeouts for Rest test client ...#19042
Conversation
There was a problem hiding this comment.
do we want to instead make socket timeout an argument to createDefaultHttpClient given most of the users may want to do this but leaving the rest as-is, as we are doing here?
There was a problem hiding this comment.
I've also increased the connect and connectionrequest timeouts. I'm not sure if users may only want to increase socket timeout...
There was a problem hiding this comment.
ok I missed that. I wouldn't increase just everything here. Connection request timeout is about retrieving tcp connections from the internal pool that the http client has, I wouldn't touch that.
As for for connect timeout, not sure either, especially because we are not hitting a connection timeout but a socket timeout in our tests.
I don't like the fact that we have to copy the whole createDefaultHttpClient method here. But this is a usability concern that we can address in a separate issue.
There was a problem hiding this comment.
agree, we should make it easier to adapt this one setting.
I've just modified the socket timeout as per your suggestion.
94e427e to
0a5ff45
Compare
* master: (416 commits) docs: removed obsolete information, percolator queries are not longer loaded into jvm heap memory. Upgrade JNA to 4.2.2 and remove optionality [TEST] Increase timeouts for Rest test client (#19042) Update migrate_5_0.asciidoc Add ThreadLeakLingering option to Rest client tests Add a MultiTermAwareComponent marker interface to analysis factories. #19028 Attempt at fixing IndexStatsIT.testFilterCacheStats. Fix docs build. Move templates out of the Search API, into lang-mustache module revert - Inline reroute with process of node join/master election (#18938) Build valid slices in SearchSourceBuilderTests Docs: Convert aggs/misc to CONSOLE Docs: migration notes for _timestamp and _ttl Group client projects under :client [TEST] Add client-test module and make client tests use randomized runner directly Move upgrade test to upgrade from version 2.3.3 Tasks: Add completed to the mapping Fail to start if plugin tries broken onModule Remove duplicated read byte array methods Rename `fields` to `stored_fields` and add `docvalue_fields` ...
... to fix failing tests.