index shard should be able to cancel check index on close.#18839
Merged
bleskes merged 1 commit intoelastic:masterfrom Jun 20, 2016
Merged
index shard should be able to cancel check index on close.#18839bleskes merged 1 commit intoelastic:masterfrom
bleskes merged 1 commit intoelastic:masterfrom
Conversation
Contributor
Author
|
@s1monw wdyt? |
Contributor
|
LGTM |
bleskes
added a commit
that referenced
this pull request
Jun 21, 2016
``` > Throwable #1: java.lang.RuntimeException: file handle leaks: [SeekableByteChannel(/var/lib/jenkins/workspace/elastic+elasticsearch+master+g1gc/core/build/testrun/integTest/J0/temp/org.elasticsearch.search.suggest.CompletionSuggestSearch2xIT_518545A20D129C8C-001/tempDir-001/data/nodes/1/indices/4sTECv6WSJOJsw9L4CGamg/0/index/segments_1), SeekableByteChannel(/var/lib/jenkins/workspace/elastic+elasticsearch+master+g1gc/core/build/testrun/integTest/J0/temp/org.elasticsearch.search.suggest.CompletionSuggestSearch2xIT_518545A20D129C8C-001/tempDir-001/data/nodes/1/indices/4sTECv6WSJOJsw9L4CGamg/0/index/segments_1)] > at __randomizedtesting.SeedInfo.seed([518545A20D129C8C]:0) > at org.apache.lucene.mockfile.LeakFS.onClose(LeakFS.java:63) > at org.apache.lucene.mockfile.FilterFileSystem.close(FilterFileSystem.java:77) > at org.apache.lucene.mockfile.FilterFileSystem.close(FilterFileSystem.java:78) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.lang.Exception > at org.apache.lucene.mockfile.LeakFS.onOpen(LeakFS.java:46) > at org.apache.lucene.mockfile.HandleTrackingFS.callOpenHook(HandleTrackingFS.java:81) > at org.apache.lucene.mockfile.HandleTrackingFS.newByteChannel(HandleTrackingFS.java:271) > at org.apache.lucene.mockfile.FilterFileSystemProvider.newByteChannel(FilterFileSystemProvider.java:212) > at org.apache.lucene.mockfile.HandleTrackingFS.newByteChannel(HandleTrackingFS.java:240) > at java.nio.file.Files.newByteChannel(Files.java:361) > at java.nio.file.Files.newByteChannel(Files.java:407) > at org.apache.lucene.store.SimpleFSDirectory.openInput(SimpleFSDirectory.java:77) > at org.apache.lucene.store.FilterDirectory.openInput(FilterDirectory.java:94) > at org.apache.lucene.util.LuceneTestCase.slowFileExists(LuceneTestCase.java:2695) > at org.apache.lucene.store.MockDirectoryWrapper.openInput(MockDirectoryWrapper.java:737) > at org.apache.lucene.store.FilterDirectory.openInput(FilterDirectory.java:94) > at org.elasticsearch.common.lucene.Lucene$1.doBody(Lucene.java:237) > at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:685) > at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:637) > at org.elasticsearch.common.lucene.Lucene.checkSegmentInfoIntegrity(Lucene.java:242) > at org.elasticsearch.index.store.Store$MetadataSnapshot.loadMetadata(Store.java:847) > at org.elasticsearch.index.store.Store$MetadataSnapshot.<init>(Store.java:740) > at org.elasticsearch.index.store.Store.getMetadata(Store.java:260) > at org.elasticsearch.index.store.Store.getMetadata(Store.java:240) > at org.elasticsearch.index.shard.IndexShard.doCheckIndex(IndexShard.java:1310) > at org.elasticsearch.common.util.CancellableThreads.executeIO(CancellableThreads.java:102) > at org.elasticsearch.index.shard.IndexShard.checkIndex(IndexShard.java:1288) > at org.elasticsearch.index.shard.IndexShard.internalPerformTranslogRecovery(IndexShard.java:921) > at org.elasticsearch.index.shard.IndexShard.skipTranslogRecovery(IndexShard.java:964) > at org.elasticsearch.indices.recovery.RecoveryTarget.prepareForTranslogOperations(RecoveryTarget.java:297) > at ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If someone sets
index.shard.check_on_startup, indexing start up time can be slow (by design, it diligently goes and checks all data). If for some reason the shard is closed in that time, the store ref is kept around and prevents a new shard copy to be allocated to this node via the shard level locks. This is especially tricky if the shard is close due to a cancelled recovery which may re-restart soon.This PR adds a cancellable threads instance to each IndexShard and perform index checking underneath it, so it can be cancelled on close. This assumes that:
Relates to #12011
PS. We are also discussing not doing a full index check on peer recovery but rather just do a checksum check.