[TEST] wait for yellow after setup doc tests#18726
Merged
brwe merged 2 commits intoelastic:masterfrom Jun 3, 2016
Merged
Conversation
We have many places in the doc where we expect and index to be yellow before we execute a query. Therefore we have to always wait for yellow after setup.
| current.println('---') | ||
| current.println("setup:") | ||
| body(setup) | ||
| body(waitForYellow) |
Member
There was a problem hiding this comment.
I'd probably just current.println the wait_for_yellow stuff. Like, you can even use normal rest-yaml syntax and everything in here.
Member
|
I'm still hoping for #9126 but in the mean time this should help. It won't get everything because we have cases where we use make an index and use it in the same snippet, but this'll still help. |
Contributor
Author
|
@nik9000 addressed your comment. Thank you! |
Member
|
LGTM |
jasontedor
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jun 3, 2016
* master: (911 commits) [TEST] wait for yellow after setup doc tests (elastic#18726) Fix recovery throttling to properly handle relocating non-primary shards (elastic#18701) Fix merge stats rendering in RestIndicesAction (elastic#18720) [TEST] mute RandomAllocationDeciderTests.testRandomDecisions Reworked docs for index-shrink API (elastic#18705) Improve painless compile-time exceptions Adds UUIDs to snapshots Add test rethrottle test case for delete-by-query Do not start scheduled pings until transport start Adressing review comments Only filter intial recovery (post API) when shrinking an index (elastic#18661) Add tests to check that toQuery() doesn't return null Removing handling of null lucene query where we catch this at parse time Handle empty query bodies at parse time and remove EmptyQueryBuilder Mute failing assertions in IndexWithShadowReplicasIT until fix Remove allow running as root Add upgrade-not-supported warning to alpha release notes remove unrecognized javadoc tag from matrix aggregation module set ValuesSourceConfig fields as private Adding MultiValuesSource support classes and documentation to matrix stats agg module ...
jasontedor
added a commit
that referenced
this pull request
Jun 6, 2016
* master: (184 commits) Add back pending deletes (#18698) refactor matrix agg documentation from modules to main agg section Implement ctx.op = "delete" on _update_by_query and _reindex Close SearchContext if query rewrite failed Wrap lines at 140 characters (:qa projects) Remove log file painless: Add support for the new Java 9 MethodHandles#arrayLength() factory (see https://bugs.openjdk.java.net/browse/JDK-8156915) More complete exception message in settings tests Use java from path if JAVA_HOME is not set Fix uncaught checked exception in AzureTestUtils [TEST] wait for yellow after setup doc tests (#18726) Fix recovery throttling to properly handle relocating non-primary shards (#18701) Fix merge stats rendering in RestIndicesAction (#18720) [TEST] mute RandomAllocationDeciderTests.testRandomDecisions Reworked docs for index-shrink API (#18705) Improve painless compile-time exceptions Adds UUIDs to snapshots Add test rethrottle test case for delete-by-query Do not start scheduled pings until transport start Adressing review comments ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have many places in the doc where we expect and index to be
yellow before we execute a query. Therefore we have to
always wait for yellow after setup.
Related test failure (I think): https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+g1gc/606/consoleText