Acknowledge index deletion requests based on standard cluster state acknowledgment#18602
Merged
ywelsch merged 1 commit intoelastic:masterfrom Jun 1, 2016
Merged
Conversation
Contributor
|
@ywelsch and I talked about it offline, discussing the fact that this change uses two ack mechanism layered on top of each other (with two futures, two timeouts etc.) which makes things complex. We are currently evaluating whether specific index store deletion acks are needed now that we have uuids as folder names and based on that decide whether we want to invest more time here or just move to the standard cluster state based ack-ing. |
aa82f16 to
6373304
Compare
Contributor
Author
|
@bleskes I've updated the PR by removing the custom ack mechanism and relying only on the standard cluster state ack. |
Contributor
|
LGTM. Best stats ever. Can you update the PR description/title? |
Contributor
Author
|
Thanks @bleskes! I've updated title/description. |
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Jun 1, 2016
…fter index deletion acknowledged Relates to elastic#18602
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Jun 6, 2016
Triggering the pending deletes logic was accidentally removed in the clean up PR elastic#18602.
ywelsch
added a commit
that referenced
this pull request
Jun 6, 2016
Triggering the pending deletes logic was accidentally removed in the clean up PR #18602.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index deletion requests currently use a custom acknowledgement mechanism that wait for the data nodes to actually delete the data before acknowledging the request to the client. This was initially put into place as a new index with same name could only be created if the old index was wiped as we used the index name as data folder on the data nodes. With PR #16442, we now use the index uuid as folder name which avoids collision between indices that are named the same (deleted and recreated). This allows us to get rid of the custom acknowledgment mechanism altogether and rely on the standard cluster state-based acknowledgment instead.
Closes #18558