AggregatorBuilder and PipelineAggregatorBuilder do not need generics.#18368
Merged
jpountz merged 1 commit intoelastic:masterfrom Jun 1, 2016
Merged
AggregatorBuilder and PipelineAggregatorBuilder do not need generics.#18368jpountz merged 1 commit intoelastic:masterfrom
jpountz merged 1 commit intoelastic:masterfrom
Conversation
6733a9f to
d1a2a49
Compare
Contributor
There was a problem hiding this comment.
Why do we need to import both PipelineAggregatorBuilder and AbstractPipelineAggregatorBuilder here?
Contributor
|
@jpountz I left some minor comments but LGTM |
…lastic#18368 Similar reasoning as elastic#18133 but for the aggs API. One important change is that I moved the base PipelineAggregatorBuilder class to the o.e.s.aggregations package instead of o.e.s.aggregations.pipeline so that the create method does not need to be public.
d1a2a49 to
a78c7d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar reasoning as #18133 but for the aggs API. One important change is that
I moved the base PipelineAggregatorBuilder class to the o.e.s.aggregations
package instead of o.e.s.aggregations.pipeline so that the create method does
not need to be public.