Make MappedFieldType responsible for providing a parser/formatter.#17546
Merged
jpountz merged 2 commits intoelastic:masterfrom Apr 7, 2016
Merged
Make MappedFieldType responsible for providing a parser/formatter.#17546jpountz merged 2 commits intoelastic:masterfrom
jpountz merged 2 commits intoelastic:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Should we add a test of this method in BytesStreamTests? (see comment here: #17351 (comment))
Contributor
Author
There was a problem hiding this comment.
I added serialization tests, but in a dedicated test in the same package as DocValeFormat so that I can assert on the value of pkg protected fields without exposing anything to the public
Contributor
|
@jpountz I left a few comments. |
b0db200 to
3cbd49e
Compare
Contributor
Author
|
I pushed commits to address your comments. |
Contributor
|
LGTM |
…ccuracy of doc counts.
…astic#17546 Aggregations need to perform instanceof calls on MappedFieldType instances in order to know how they should be parsed or formatted. Instead, we should let the field types provide a formatter/parser that can can be used.
3cbd49e to
c33300c
Compare
nknize
added a commit
to nknize/elasticsearch
that referenced
this pull request
May 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aggregations need to perform instanceof calls on MappedFieldType instances in
order to know how they should be parsed or formatted. Instead, we should let
the field types provide a formatter/parser that can can be used.