Add fromXContent method to SuggestBuilder#16505
Merged
cbuescher merged 1 commit intoelastic:feature-suggest-refactoringfrom Feb 9, 2016
Merged
Add fromXContent method to SuggestBuilder#16505cbuescher merged 1 commit intoelastic:feature-suggest-refactoringfrom
cbuescher merged 1 commit intoelastic:feature-suggest-refactoringfrom
Conversation
|
@cbuescher LGTM, I made one change, making the text field a ParseField instead of just a string literal. I was not able to create a PR to your branch (I don't think I have permissions to your repo), so I just created this PR here: #16510. I can squash the commits into one if you think its OK. |
f02146a to
68230ad
Compare
Member
Author
68230ad to
c5015ac
Compare
c5015ac to
9abf00b
Compare
cbuescher
added a commit
that referenced
this pull request
Feb 9, 2016
Add fromXContent method to SuggestBuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to parse from xContent to the SuggestBuilder. Borrowing some test infrastructure code (WritableTestCase) from #16398 and extending it to be also able to use NamedWritable streamsl.