Implements creating a term suggester from x-content#16483
Conversation
8ff1c12 to
57f1d29
Compare
|
@abeyad I took a first look and only left a few minor things as comments. Can you also activate the testFromXContent() tests in TermSuggestionBuilderTests? When I did that they were still failing for me. Maybe you can take a look, I guess there might be still some things missing from the parser or some parameters not surviving the roundtrip correctly. |
57f1d29 to
ab43cb8
Compare
|
@cbuescher I implemented the changes and all tests pass now. |
There was a problem hiding this comment.
nit: we almost never use Locale.US exept for some number formating. While I think it doesn't make a difference for the enum names in question here, I'd suggest going with Locale.ROOT
ab43cb8 to
8c00f36
Compare
|
@cbuescher I changed all |
There was a problem hiding this comment.
Why these changes? I first thought it's because the method rename but it seems unrelated to your change now. If so, can you change this back?
There was a problem hiding this comment.
good catch, it was my IDE, my fault
8c00f36 to
7ca7254
Compare
|
@cbuescher made the changes |
|
Thanks, LGTM now. |
Feature term suggester xcontent
No description provided.