Add SmoothingModel and candidate generator serialization to PhraseSuggestionBuilder#16309
Merged
cbuescher merged 3 commits intoelastic:feature-suggest-refactoringfrom Feb 1, 2016
Conversation
4434bb4 to
a9ba1e7
Compare
aa9af12 to
d38a1b4
Compare
Contributor
There was a problem hiding this comment.
Can we name this method readPhraseSuggesterSmoothingModel() so it doesn't confuse with other smoothing models we might have in the future (e.g. for a interpolating pipeline aggregator)?
Contributor
|
Left one comment but LGTM |
cbuescher
added a commit
that referenced
this pull request
Feb 1, 2016
With SmoothingModels and CandidateGenerator now beeing able to be serialized via NamedWritable infrastructure, PhraseSuggestionBuilder can now properly delegate read/write and equals/hashCode to their implementations. Also adding randomization of smoothing model and candidate generators to tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With SmoothingModels and CandidateGenerator now beeing able to be serialized via NamedWritable infrastructure, PhraseSuggestionBuilder can now properly delegate read/write and equals/hashCode to their implementations. Also adding randomization of smoothing model and candidate generators to tests.