Left two small comments. OTT LGTM

@talevy @martijnvg I think this PR should be reverted and we should use out existing exception infrastructure for this. You can set headers on all ElasticsearchExceptions that get's rendered in a strucutred way. There is no reason to add so much custom code we have a streamlined way to do this.

you can just do something like this:

try {
 // configure
} catch (Exception ex) {
 ElasticsearchException e = new ElasticsearchException("failed to configure pipeline", ex);
 e.addHeader("processor", "grok");
 e.addHeader("what_have_you", "boom");
  throw e;
}

this will get rendered as:

{
  "type" : "exception",
  "reason" : "failed to configure pipeline",
  "caused_by" : {
    "type" : "illegal_argument_exception",
    "reason" : "something is wrong"
  },
  "header" : {
    "what_have_you" : "boom",
    "processor" : "grok"
  }
}

interesting, I was not familiar with this header functionality. thanks for the suggestion!

do we want to do this. shall I preserve the ConfigurationPropertyException and then wrap this during the same time that we have all the PipelineFactoryError logic? that would really clean up that level, you're right. I'll start off with that, and we can push it down further if that is suitable.

do we want to do this. shall I preserve the ConfigurationPropertyException and then wrap this during the same time that we have all the PipelineFactoryError logic? that would really clean up that level, you're right. I'll start off with that, and we can push it down further if that is suitable.

Discussed this we only throw SearchParseException and add headers from the processors and ConfigurationUtils. The PipelineFactoryError logic and ConfigurationPropertyException are no longer needed.

@martijnvg I think ElasticsearchParseException is what we should throw

oh and @talevy @martijnvg by reverting I mean not back it out just use the existing mechanism. :)

thanks

@martijnvg I think ElasticsearchParseException is what we should throw

Agreed ElasticsearchParseException is better otherwise we're forced to pass down null arguments.

confirming here that I am working on migrating to ElasticsearchParseException! thanks

PR for this fix can be found here: #16355