Remove version in ShardRouting (now obsolete)#16243
Merged
ywelsch merged 1 commit intoelastic:masterfrom Feb 4, 2016
Merged
Conversation
Contributor
There was a problem hiding this comment.
does this check make any sense now that we have no versions?
Contributor
Author
There was a problem hiding this comment.
I replaced the check by an equals (no need to ignore metadata now). The check is still needed as we only want to call the shardRoutingChanged listener later if something changed.
Contributor
|
This is great. Left some minor comments here and there... |
Contributor
Author
|
@bleskes pushed a new set of changes |
7 tasks
1171f07 to
6646f1e
Compare
Contributor
Author
|
@bleskes I rebased on current master (there were lots of conflicts due to the changes in Index class) |
Contributor
|
Thanks @ywelsch . Left some extremely minor comments. Feel free to address them and push when ready (or ping me if you feel another cycle is needed). |
ca8c1d9 to
bc49905
Compare
bc49905 to
4937531
Compare
ywelsch
pushed a commit
that referenced
this pull request
Feb 4, 2016
Remove obsolete version in ShardRouting
| writeReason = "freshly started, version [" + newRouting.version() + "]"; | ||
| } else if (currentRouting.version() < newRouting.version()) { | ||
| writeReason = "version changed from [" + currentRouting.version() + "] to [" + newRouting.version() + "]"; | ||
| writeReason = "freshly started, allocation id [" + newRouting.allocationId() + "]"; |
Contributor
There was a problem hiding this comment.
fyi - this gives you double [[]]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes in #14739, allocation ids are now being used to select primary shards instead of version information stored with the shard state on disk. As this was the only use case so far to carry version information in shard routing, we can safely remove it.