Prefer nodes that previously held primary shard for primary shard allocation#16096
Merged
ywelsch merged 1 commit intoelastic:masterfrom Jan 20, 2016
Merged
Conversation
7 tasks
Contributor
|
Thanks @ywelsch . I was originally thinking of a simpler approach (at least, I think so) - extend NodeGatewayStartedShards to include the primary flag, which we store and use that. This means the change is limited to |
Contributor
Author
|
My concern for relying on |
3218bf9 to
1eb8d5b
Compare
Contributor
Author
|
@bleskes I updated the PR. can you have a look? |
Contributor
|
LGTM. Love the stats +81 -47 (most of it is tests). |
ywelsch
pushed a commit
that referenced
this pull request
Jan 20, 2016
Prefer nodes that previously held primary shard for primary shard allocation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocation ids are currently used during primary shard allocation to decide which nodes have non-stale copies of the shard data. Instead of just having a set of allocation ids representing the shard copies that have been last active, we can order this set by putting allocation ids of active primaries first. This allows the primary shard allocator to prefer allocation on nodes that previously held the active primary shard.
Relates to #14739