Fix CreateIndexIT#testCreateAndDeleteIndexConcurrently#15853
Closed
s1monw wants to merge 1 commit intoelastic:masterfrom
Closed
Fix CreateIndexIT#testCreateAndDeleteIndexConcurrently#15853s1monw wants to merge 1 commit intoelastic:masterfrom
s1monw wants to merge 1 commit intoelastic:masterfrom
Conversation
The test fails in different ways since we can hit timeouts and shards not being available on retry which we simply didn't expect before but are valid. Closes elastic#15312 Closes elastic#14512
Member
There was a problem hiding this comment.
Maybe this should throw the IndexNotFoundException instead?
Contributor
There was a problem hiding this comment.
we do if the index is not there, but there is a racing condition where the index is there when we check for that and then the shards are deleted beneath us. Then we go and wait for the shards (identically to where the index is created but the shards are not assigned yet), which results in this exception. We can do another check before failing, but I don't think it's worth it for this edge case?
Member
There was a problem hiding this comment.
Fair enough. Its probably not worth it.
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Mar 15, 2016
Since elastic#16442 is merged we should be able to reenable this test as a followup of elastic#15853 - all issues blocking it have been resolved I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test fails in different ways since we can hit timeouts and shards not being available on retry
which we simply didn't expect before but are valid.
Closes #15312
Closes #14512