[Ingest] Change ExecutionService to process multiple request at a time#15593
Merged
martijnvg merged 2 commits intoelastic:feature/ingestfrom Dec 22, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
nit: rename the first argument to actionRequests?
Contributor
|
I left a couple of minor comments, LGTM otherwise. Was wondering, this changes things only for bulk requests doesn't it? It would be good to clarify that in the description of the PR. |
Member
Author
|
@javanna yes, this change only applies for bulk request. I'll update the |
5e98265 to
72fc347
Compare
Member
Author
|
@javanna I've update this PR. |
43 tasks
Contributor
|
LGTM |
martijnvg
added a commit
that referenced
this pull request
Dec 22, 2015
…actoring [Ingest] Change ExecutionService to process multiple request at a time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExecutionService should be able to process multiple index requests at a time. This change is important for the when ingest is enabled for the bulk api, so that we don't use a head per bulk item, but instead use a threed per bulk request.