Disable sequence numbers for TSDB in release builds#145737
Disable sequence numbers for TSDB in release builds#145737kkrik-es merged 11 commits intoelastic:mainfrom
Conversation
|
Hi @kkrik-es, I've created a changelog YAML for you. Note that since this PR is labelled |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
yannis-roussos
left a comment
There was a problem hiding this comment.
Thank you @kkrik-es, the explanation on the changelog looks great and fully covers the change, impact and how to mitigate
romseygeek
left a comment
There was a problem hiding this comment.
A couple of nits around wording, but no need for another review. I take it that the plan is to remove the feature flag in a separate PR?
Co-authored-by: Alan Woodward <romseygeek@gmail.com>
Co-authored-by: Alan Woodward <romseygeek@gmail.com>
# Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java
# Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java
🔍 Preview links for changed docs⏳ Building and deploying preview... View progress This comment will be updated with preview links when the build is complete. |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
* Disable sequence numbers for TSDB in release builds * relax validation * [CI] Auto commit changes from spotless * Update docs/changelog/145737.yaml * breaking * breaking tag * Update 145737.yaml * Update docs/changelog/145737.yaml Co-authored-by: Alan Woodward <romseygeek@gmail.com> * Update docs/changelog/145737.yaml Co-authored-by: Alan Woodward <romseygeek@gmail.com> --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> Co-authored-by: Alan Woodward <romseygeek@gmail.com>
This change allows for trimming sequence numbers when they are no longer needed for replication, with substantial savings in storage and cpu for segment merging. The downside is that Optimistic Concurrency Control (OCC) gets disabled. This is a reasonable tradeoff for metrics applications, where updates and deletes are rather infrequent and hardly need isolation guarantees. Still, if OCC is important for a given application, sequence numbers can be restored by setting
[index.disable_sequence_numbers:true].Fixes #136305