Fix Golden Tests for Round To#145651
Merged
not-napoleon merged 2 commits intoelastic:mainfrom Apr 6, 2026
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
approved these changes
Apr 6, 2026
Contributor
ivancea
left a comment
There was a problem hiding this comment.
LGTM, thanks! Looks like a "conflict" as you said; checked the changes and they look as expected now
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
resolves elastic#145381 I think this is a sequencing conflict with elastic#141272, which applied a similar change to many other golden tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #145381
I think this is a sequencing conflict with #141272, which applied a similar change to many other golden tests. Tagging @ivancea for a review, since he authored that change and can verify that these new plans look correct.