ES|QL: Remove implicit limit for FORK#145429
Merged
ioanatia merged 14 commits intoelastic:mainfrom Apr 8, 2026
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
ioanatia
commented
Apr 7, 2026
| public static final Setting<String> EXTERNAL_DISTRIBUTION = Setting.simpleString("external_distribution", "adaptive"); | ||
|
|
||
| public static final Setting<Boolean> FORK_IMPLICIT_LIMIT = Setting.boolSetting("fork_implicit_limit", true); | ||
| public static final Setting<Boolean> FORK_IMPLICIT_LIMIT = Setting.boolSetting("fork_implicit_limit", false); |
Member
Author
There was a problem hiding this comment.
I will remove this in a follow up PR, together with the Analyzer rule that adds the implicit limit based on the pragma value.
carlosdelest
approved these changes
Apr 7, 2026
Member
carlosdelest
left a comment
There was a problem hiding this comment.
LGTM, one step closer! 🚀
| containsString("FUSE can only be used on a limited number of rows. Consider adding a LIMIT before FUSE.") | ||
| ); | ||
|
|
||
| defaultAnalyzer().error( |
Member
There was a problem hiding this comment.
This is a breaking change - I think it's ok as we're tech preview, but maybe we need to add a release note about it?
Member
Author
There was a problem hiding this comment.
good thinking, will adapt the docs in a follow up as well
Collaborator
|
Hi @ioanatia, I've created a changelog YAML for you. |
ioanatia
commented
Apr 7, 2026
| "function cannot operate on \\[from .*\\], which is not a field from an index mapping", | ||
| // https://github.com/elastic/elasticsearch/issues/145570 | ||
| "function cannot operate on \\[\\], which is not a field from an index mapping", | ||
| "function cannot operate on \\[.*\\], which is not a field from an index mapping", |
Member
Author
There was a problem hiding this comment.
unrelated to this PR, just fixes GenerativeIT for which we kept getting failures on this branch
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related
#121652
Currently each FORK branch receives an implicit LIMIT.
Take for example:
this is actually equivalent to:
This can be a surprising behaviour for users.
It also limits the utility of FORK.
In this PR, we remove adding the implicit LIMIT to each fork branch.
This is one the last changes before we GA FORK.