Move DLM signalling error retry setting into core#145371
Merged
dakrone merged 4 commits intoelastic:mainfrom Apr 1, 2026
Merged
Move DLM signalling error retry setting into core#145371dakrone merged 4 commits intoelastic:mainfrom
dakrone merged 4 commits intoelastic:mainfrom
Conversation
This moves the `DATA_STREAM_SIGNALLING_ERROR_RETRY_INTERVAL_SETTING` setting into the core module so that it can be used by both the regular DLM service and the frozen conversion bits to set up the retry interval in the DLM error store. Relates to elastic#145243
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lukewhiting
requested changes
Apr 1, 2026
Contributor
lukewhiting
left a comment
There was a problem hiding this comment.
The tread pool issue should probably be addressed but the other two are non blocking.
...s/src/test/java/org/elasticsearch/datastreams/lifecycle/DataStreamLifecycleServiceTests.java
Outdated
Show resolved
Hide resolved
.../elasticsearch/datastreams/lifecycle/health/DataStreamLifecycleHealthInfoPublisherTests.java
Outdated
Show resolved
Hide resolved
...ition/src/test/java/org/elasticsearch/xpack/dlm/frozen/DlmFrozenTransitionExecutorTests.java
Outdated
Show resolved
Hide resolved
lukewhiting
approved these changes
Apr 1, 2026
Contributor
lukewhiting
left a comment
There was a problem hiding this comment.
LGTM 👍🏻 Thanks for making the changes
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
* Move DLM signalling error retry setting into core This moves the `DATA_STREAM_SIGNALLING_ERROR_RETRY_INTERVAL_SETTING` setting into the core module so that it can be used by both the regular DLM service and the frozen conversion bits to set up the retry interval in the DLM error store. Relates to elastic#145243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the
DATA_STREAM_SIGNALLING_ERROR_RETRY_INTERVAL_SETTINGsetting into the core module so that it can be used by both the regular DLM service and the frozen conversion bits to set up the retry interval in the DLM error store.Relates to #145243