Skip to content

ESQL: Fix ROUND_TO tests#145247

Merged
nik9000 merged 4 commits intoelastic:mainfrom
nik9000:fix_round_to_edge_bug
Mar 31, 2026
Merged

ESQL: Fix ROUND_TO tests#145247
nik9000 merged 4 commits intoelastic:mainfrom
nik9000:fix_round_to_edge_bug

Conversation

@nik9000
Copy link
Copy Markdown
Member

@nik9000 nik9000 commented Mar 30, 2026

It's a boundary condition thing - > vs >=.

Closes #145245

It's a boundary condition thing - `>` vs `>=`.

Closes elastic#145245
@nik9000 nik9000 requested a review from dnhatn March 30, 2026 23:12
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v9.4.0 labels Mar 30, 2026
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 30, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Copy Markdown
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @nik9000

@nik9000 nik9000 enabled auto-merge (squash) March 31, 2026 00:30
@nik9000 nik9000 merged commit 97e9b78 into elastic:main Mar 31, 2026
35 checks passed
@dnhatn dnhatn mentioned this pull request Mar 31, 2026
dnhatn added a commit that referenced this pull request Mar 31, 2026
Closes #145254
Closes #145255
Closes #145256
Closes #145259
Closes #145275
Closes #145276
Closes #145277
Closes #145289
Closes #145257
Closes #145289

Relates #145247
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Apr 1, 2026
It's a boundary condition thing - `>` vs `>=`.

Closes elastic#145245
mromaios pushed a commit to mromaios/elasticsearch that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] RoundToTests testCrankyEvaluateBlockWithoutNulls {TestCase=<int, 20 fixed-interval ints>} failing

3 participants