Fix dense_vector default index options when using BFLOAT16#145202
Merged
Mikep86 merged 14 commits intoelastic:mainfrom Mar 31, 2026
Merged
Fix dense_vector default index options when using BFLOAT16#145202Mikep86 merged 14 commits intoelastic:mainfrom
Mikep86 merged 14 commits intoelastic:mainfrom
Conversation
Collaborator
|
Hi @Mikep86, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
thecoop
approved these changes
Mar 30, 2026
!!!
Contributor
Author
|
@benwtrent @thecoop This could use another look. I had to add an index version to gate when we apply default index options to fix BwC. And we still need to backport the index version to 9.3.x... |
kkharbas
approved these changes
Mar 31, 2026
Contributor
Author
|
@elasticmachine update branch |
thecoop
reviewed
Mar 31, 2026
server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Mar 31, 2026
...er/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTestUtils.java
Outdated
Show resolved
Hide resolved
…com:Mikep86/elasticsearch into dense-vector_bfloat16-default-index-options
benwtrent
approved these changes
Mar 31, 2026
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 31, 2026
…rics
* upstream/main: (21 commits)
Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:external-basic.topSnippetsFunction} elastic#145353
Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:external-basic.scoreFunction} elastic#145352
[DiskBBQ] Fix bug in NeighborQueue#popRawAndAddRaw (elastic#145324)
Fix dense_vector default index options when using BFLOAT16 (elastic#145202)
Use checked exceptions in entitlement constructor rules (elastic#145234)
ESQL: DS: datasource file plugins should not return TEXT types (elastic#145334)
Plumb DLM error store through to DlmFrozenTransition classes (elastic#145243)
Make Settings.Builder.remove() fluent (elastic#145294)
Add FLS tests for METRICS_INFO and TS_INFO (elastic#145211)
Fix flaky SecurityFeatureResetTests (elastic#145063)
[DOCS] Fix conflict markers in ESQL processing command list (elastic#145338)
Skip certain metric assertions on Windows (elastic#144933)
[ES|QL] Add schema reconciliation for multi-file external sources (elastic#145220)
Simplify DiskBBQ dynamic visit ratio to linear (elastic#142784)
ESQL: Disallow unmapped_fields=load with partial non-KEYWORD (elastic#144109)
[Transform] Track Linked Projects (elastic#144399)
Fix bulk scoring to process last batch instead of falling through to scalar tail (elastic#145316)
Clean up TickerScheduleEngineTests (elastic#145303)
[CI] ShardBulkInferenceActionFilterIT testRestart - Ensuring that secrets-inference index is available after full restart and unmuting test (elastic#145317)
Add CRUD doc to the DistributedArchitectureGuide (elastic#144710)
...
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Mar 31, 2026
…45202) There is a bug in the dense_vector field mapper where default index options will be set to null when the element type is BFLOAT16. This PR fixes that by handling BFLOAT16 as equivalent to FLOAT and adding a default index options test. (cherry picked from commit d807c64) # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # server/src/main/java/org/elasticsearch/inference/SimilarityMeasure.java
Mikep86
added a commit
that referenced
this pull request
Mar 31, 2026
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Apr 1, 2026
…45202) There is a bug in the dense_vector field mapper where default index options will be set to null when the element type is BFLOAT16. This PR fixes that by handling BFLOAT16 as equivalent to FLOAT and adding a default index options test.
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
…45202) There is a bug in the dense_vector field mapper where default index options will be set to null when the element type is BFLOAT16. This PR fixes that by handling BFLOAT16 as equivalent to FLOAT and adding a default index options test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the
dense_vectorfield mapper where default index options will be set tonullwhen the element type isBFLOAT16. This PR fixes that by handlingBFLOAT16as equivalent toFLOATand adding a default index options test.Fixes #145204