Add comment about stack overflow to ThrottledIterator#145185
Merged
DaveCTurner merged 3 commits intoelastic:mainfrom Apr 7, 2026
Merged
Conversation
On reading this class again a few months after elastic#139988 it took some time to work this out. Adding a comment for the next person.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
andreidan
approved these changes
Mar 30, 2026
Contributor
andreidan
left a comment
There was a problem hiding this comment.
Thanks for adding this David
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
On reading this class again a few months after elastic#139988 it took some time to work this out. Adding a comment for the next person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On reading this class again a few months after #139988 it took some time
to work this out. Adding a comment for the next person.