Allow for confidence_interval:0.0 to be removed#144739
Merged
davidkyle merged 7 commits intoelastic:mainfrom Mar 25, 2026
Merged
Allow for confidence_interval:0.0 to be removed#144739davidkyle merged 7 commits intoelastic:mainfrom
davidkyle merged 7 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
eranweiss-elastic
pushed a commit
to eranweiss-elastic/elasticsearch
that referenced
this pull request
Mar 25, 2026
seanzatzdev
pushed a commit
to seanzatzdev/elasticsearch
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect #143980 fails because previously
confidence_intervaldefaulted to 0.0f if not set which meant it was always written in toXContent.The BWC tests fail if the new node has created the index mapping without an explicit confidence_interval, the new node will not default confidence_interval so it is not written in toXContent. When the old node reads the mapping it defaults confidence_interval to 0.0 on parsing then includes that field in the toXContent representation. The assertion fails because the mapping on the new node does not contain confidence_interval but the mapping on the old node does.
Fixes #143980