Test task status/reason consistency before cancellation#144716
Merged
michalborek merged 4 commits intoelastic:mainfrom Mar 24, 2026
Merged
Test task status/reason consistency before cancellation#144716michalborek merged 4 commits intoelastic:mainfrom
michalborek merged 4 commits intoelastic:mainfrom
Conversation
60b5174 to
f566553
Compare
DaveCTurner
reviewed
Mar 23, 2026
...r/src/test/java/org/elasticsearch/action/admin/cluster/node/tasks/CancellableTasksTests.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Mar 23, 2026
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM but @szybia's approval is enough
michalborek
added a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 24, 2026
* Test task status/reason consistency before cancellation * Fix potential flakiness of the test * [CI] Auto commit changes from spotless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure the cancellation reason is consistently null before the task is cancelled, the assertion was moved to a while block.