Add back integ tests to distributions#14460
Merged
rjernst merged 3 commits intoelastic:masterfrom Nov 3, 2015
Merged
Conversation
rpm and deb are still skipped, but this configures rest tests to run for zip and tgz distributions closes elastic#14361
Contributor
|
I first tried this out from distribution/zip, maybe a missing dependency? I'm trying from the top-level build now. |
Contributor
|
There are also quite a few things missing (just from looking at directory structure) that integ tests did before:
While these may seem "unimportant", I do think they are pretty common problems and these are easy tricks to prevent issues later. |
Contributor
There was a problem hiding this comment.
do we have an equivalent for the environment properties being set? These are fairly important, at least JAVA_HOME:
Contributor
|
Works for me. I left some comments, all can be followups. |
Member
Author
Member
Author
|
And I fixed the dependency issue. Running the tests within |
Contributor
|
+1 |
Member
Author
|
I also added the environment variables back in this PR. |
rjernst
added a commit
that referenced
this pull request
Nov 3, 2015
Add back integ tests to distributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rpm and deb are still skipped, but this configures rest tests to run for
zip and tgz distributions
closes #14361