Skip to content

Fix ignored_source_as_doc_values feature flag handling in tests.#144546

Merged
martijnvg merged 5 commits intoelastic:mainfrom
martijnvg:fix_ignored_source_as_doc_values_ff_test_failures
Mar 19, 2026
Merged

Fix ignored_source_as_doc_values feature flag handling in tests.#144546
martijnvg merged 5 commits intoelastic:mainfrom
martijnvg:fix_ignored_source_as_doc_values_ff_test_failures

Conversation

@martijnvg
Copy link
Copy Markdown
Member

@martijnvg martijnvg commented Mar 19, 2026

Closes #144540
Closes #144531
Closes #144530
Closes #144528
Closes #144527

@martijnvg martijnvg added >test Issues or PRs that are addressing/adding tests :StorageEngine/Mapping The storage related side of mappings labels Mar 19, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Mar 19, 2026

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@craigtaverner craigtaverner mentioned this pull request Mar 19, 2026
Closed
romseygeek
romseygeek approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tag with test-release as well?

@martijnvg martijnvg added the test-release Trigger CI checks against release build label Mar 19, 2026
@martijnvg
Copy link
Copy Markdown
Member Author

martijnvg commented Mar 19, 2026

Tag with test-release as well?

yes, but I forgot to add the label 🤦

@martijnvg martijnvg enabled auto-merge (squash) March 19, 2026 12:40
sidosera
sidosera approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sidosera sidosera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@bpintea
Copy link
Copy Markdown
Contributor

bpintea commented Mar 19, 2026

elasticsearch-ci/checkPart3 / release-tests caused by ExternalDistributedResilienceIT > testPathFilteredFaultsOnlyAffectParquetReads FAILED which is fixed in #144552, but waiting on this PR to pass too. I think we'll have to merge one of them without a clean test-release CI.

@martijnvg
Copy link
Copy Markdown
Member Author

martijnvg commented Mar 19, 2026

@bpintea I will merge my PR now. I also getting some other flaky test failures, which are unrelated.

@martijnvg martijnvg disabled auto-merge March 19, 2026 15:43
@martijnvg martijnvg merged commit 6149de0 into elastic:main Mar 19, 2026
32 of 38 checks passed
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Mar 20, 2026
@martijnvg @ncordon
Fix ignored_source_as_doc_values feature flag handling in tests. (ela…
1c97a35 
…stic#144546)

Closes elastic#144540
Closes elastic#144531
Closes elastic#144530
Closes elastic#144528
Closes elastic#144527
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
@martijnvg @michalborek
Fix ignored_source_as_doc_values feature flag handling in tests. (ela…
e69686d 
…stic#144546)

Closes elastic#144540
Closes elastic#144531
Closes elastic#144530
Closes elastic#144528
Closes elastic#144527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romseygeek romseygeek romseygeek approved these changes

@sidosera sidosera sidosera approved these changes

Assignees

No one assigned

Labels

:StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.4.0

Projects

None yet

Milestone

No milestone

5 participants

@martijnvg @elasticsearchmachine @bpintea @romseygeek @sidosera