Fix StreamingXContentResponseIT#testAbort#144473
Merged
DaveCTurner merged 4 commits intoelastic:mainfrom Mar 19, 2026
Merged
Conversation
Silly test mistake: the throttle was supposed to limit the number of fragments in the queue, but was closing the throttling ref after submission rather than transmission so that the queue could grow without bound sometimes. It's been like this since the test was introduced in elastic#111933, but it only started failing recently. I suspect until the performance improvement in elastic#139988 landed it couldn't actually submit enough tasks at once to cause a failure. Closes elastic#143644
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 19, 2026
Silly test mistake: the throttle was supposed to limit the number of fragments in the queue, but was closing the throttling ref after submission rather than transmission so that the queue could grow without bound sometimes. It's been like this since the test was introduced in elastic#111933, but it only started failing recently. I suspect until the performance improvement in elastic#139988 landed it couldn't actually submit enough tasks at once to cause a failure. Closes elastic#143644
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 19, 2026
Silly test mistake: the throttle was supposed to limit the number of fragments in the queue, but was closing the throttling ref after submission rather than transmission so that the queue could grow without bound sometimes. It's been like this since the test was introduced in elastic#111933, but it only started failing recently. I suspect until the performance improvement in elastic#139988 landed it couldn't actually submit enough tasks at once to cause a failure. Closes elastic#143644
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
that referenced
this pull request
Mar 19, 2026
Silly test mistake: the throttle was supposed to limit the number of fragments in the queue, but was closing the throttling ref after submission rather than transmission so that the queue could grow without bound sometimes. It's been like this since the test was introduced in #111933, but it only started failing recently. I suspect until the performance improvement in #139988 landed it couldn't actually submit enough tasks at once to cause a failure. Closes #143644
Member
Author
|
Backported to 8.19 in 760495d |
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Mar 20, 2026
Silly test mistake: the throttle was supposed to limit the number of fragments in the queue, but was closing the throttling ref after submission rather than transmission so that the queue could grow without bound sometimes. It's been like this since the test was introduced in elastic#111933, but it only started failing recently. I suspect until the performance improvement in elastic#139988 landed it couldn't actually submit enough tasks at once to cause a failure. Closes elastic#143644
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 23, 2026
Silly test mistake: the throttle was supposed to limit the number of fragments in the queue, but was closing the throttling ref after submission rather than transmission so that the queue could grow without bound sometimes. It's been like this since the test was introduced in #111933, but it only started failing recently. I suspect until the performance improvement in #139988 landed it couldn't actually submit enough tasks at once to cause a failure. Closes #143644
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 23, 2026
Silly test mistake: the throttle was supposed to limit the number of fragments in the queue, but was closing the throttling ref after submission rather than transmission so that the queue could grow without bound sometimes. It's been like this since the test was introduced in #111933, but it only started failing recently. I suspect until the performance improvement in #139988 landed it couldn't actually submit enough tasks at once to cause a failure. Closes #143644
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
Silly test mistake: the throttle was supposed to limit the number of fragments in the queue, but was closing the throttling ref after submission rather than transmission so that the queue could grow without bound sometimes. It's been like this since the test was introduced in elastic#111933, but it only started failing recently. I suspect until the performance improvement in elastic#139988 landed it couldn't actually submit enough tasks at once to cause a failure. Closes elastic#143644
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.
It's been like this since the test was introduced in #111933, but it
only started failing recently. I suspect until the performance
improvement in #139988 landed it couldn't actually submit enough tasks
at once to cause a failure.
Closes #143644