Skip to content

Fix StreamingXContentResponseIT#testAbort#144473

Merged
DaveCTurner merged 4 commits intoelastic:mainfrom
DaveCTurner:2026/03/18/StreamingXContentResponseIT-testAbort
Mar 19, 2026
Merged

Fix StreamingXContentResponseIT#testAbort#144473
DaveCTurner merged 4 commits intoelastic:mainfrom
DaveCTurner:2026/03/18/StreamingXContentResponseIT-testAbort

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in #111933, but it
only started failing recently. I suspect until the performance
improvement in #139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes #143644

Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in elastic#111933, but it
only started failing recently. I suspect until the performance
improvement in elastic#139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes elastic#143644
@DaveCTurner DaveCTurner requested a review from ankikuma March 18, 2026 10:22
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed/Network Http and internode communication implementations auto-backport Automatically create backport pull requests when merged branch:9.2 branch:8.19 v9.4.0 branch:9.3 labels Mar 18, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Copy Markdown
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 67de22c into elastic:main Mar 19, 2026
36 checks passed
@DaveCTurner DaveCTurner deleted the 2026/03/18/StreamingXContentResponseIT-testAbort branch March 19, 2026 13:03
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Mar 19, 2026
Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in elastic#111933, but it
only started failing recently. I suspect until the performance
improvement in elastic#139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes elastic#143644
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Mar 19, 2026
Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in elastic#111933, but it
only started failing recently. I suspect until the performance
improvement in elastic#139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes elastic#143644
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
9.3
8.19 Commit could not be cherrypicked due to conflicts
9.2

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 144473

DaveCTurner added a commit that referenced this pull request Mar 19, 2026
Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in #111933, but it
only started failing recently. I suspect until the performance
improvement in #139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes #143644
@DaveCTurner
Copy link
Copy Markdown
Member Author

Backported to 8.19 in 760495d

ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Mar 20, 2026
Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in elastic#111933, but it
only started failing recently. I suspect until the performance
improvement in elastic#139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes elastic#143644
elasticsearchmachine pushed a commit that referenced this pull request Mar 23, 2026
Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in #111933, but it
only started failing recently. I suspect until the performance
improvement in #139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes #143644
elasticsearchmachine pushed a commit that referenced this pull request Mar 23, 2026
Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in #111933, but it
only started failing recently. I suspect until the performance
improvement in #139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes #143644
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Silly test mistake: the throttle was supposed to limit the number of
fragments in the queue, but was closing the throttling ref after
submission rather than transmission so that the queue could grow without
bound sometimes.

It's been like this since the test was introduced in elastic#111933, but it
only started failing recently. I suspect until the performance
improvement in elastic#139988 landed it couldn't actually submit enough tasks
at once to cause a failure.

Closes elastic#143644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Distributed/Network Http and internode communication implementations Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v8.19.14 v9.2.8 v9.3.3 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] StreamingXContentResponseIT testAbort failing

3 participants