Avoid subqueries in from command in snapshot mode#144334
Merged
GalLalouche merged 2 commits intoelastic:mainfrom Mar 17, 2026
Merged
Avoid subqueries in from command in snapshot mode#144334GalLalouche merged 2 commits intoelastic:mainfrom
GalLalouche merged 2 commits intoelastic:mainfrom
Conversation
These tests assume support for subqueries in from commands, which is
only enabled in snapshot builds.
Before, tests would fail with
```
ParsingException: line 1:48: no viable alternative at input '('
```
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
Hi @GalLalouche , would you mind having a look at these changes. They are made in collaboration with Cursor. I have zero experience so please don't trust anything ;) |
idegtiarenko
approved these changes
Mar 17, 2026
Contributor
|
I went ahead and merged this so it wouldn't block us. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2026
Unmute tests fixed in #144334.
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
These tests assume support for subqueries in from commands, which is
only enabled in snapshot builds.
Before, tests would fail with
```
ParsingException: line 1:48: no viable alternative at input '('
```
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
Unmute tests fixed in elastic#144334.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests assume support for subqueries in from commands, which is only enabled in snapshot builds.
Before, tests would fail with