Enable Prometheus plugin by default#144311
Merged
felixbarny merged 7 commits intoelastic:mainfrom Mar 27, 2026
Merged
Conversation
Removes the feature flag gating the Prometheus plugin so it is enabled in all builds, not just snapshots. Deletes `PrometheusFeatures` and its service registration, which only existed to expose a `prometheus_plugin` cluster feature for skipping yaml tests in release builds.
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @felixbarny, I've created a changelog YAML for you. |
Restores PrometheusFeatures (without the feature flag check) and its service registration so that new nodes still advertise the prometheus_plugin test feature. Without this, nodes running the new code are rejected when joining a mixed-version test cluster where older nodes have already activated the prometheus_plugin feature via the feature ratchet.
sidosera
approved these changes
Mar 24, 2026
The feature flag was deleted as part of enabling Prometheus by default, but this test file was missed.
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Mar 30, 2026
The flag was removed in elastic#144311 which enabled the Prometheus plugin by default. The test cluster setup no longer needs to explicitly enable it.
mamazzol
pushed a commit
to mamazzol/elasticsearch
that referenced
this pull request
Mar 30, 2026
Removes the feature flag gating the Prometheus plugin so it is enabled in all builds, not just snapshots. Deletes `PrometheusFeatures` and its service registration, which only existed to expose a `prometheus_plugin` cluster feature for skipping yaml tests in release builds.
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Mar 30, 2026
The flag was removed in elastic#144311 which enabled the Prometheus plugin by default. The test cluster setup no longer needs to explicitly enable it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROMETHEUS_FEATURE_FLAGfeature flag so the Prometheus plugin is enabled in all builds, not just snapshotsPrometheusFeaturesand its service registration, which only existed to expose aprometheus_plugincluster feature for skipping yaml tests in release buildsrequires: cluster_features: prometheus_pluginguard from the yaml test suite