Remove upfront OCC resolution for bulk-by-scroll and handle seq_no per index#144309
Merged
fcofdez merged 5 commits intoelastic:mainfrom Mar 17, 2026
Merged
Conversation
…r index Replace the BulkByScrollOCCResolver, which rejected mixed disable_sequence_numbers settings across indices, with per-index handling. The search phase now always requests seqNoAndPrimaryTerm (indices with sequence numbers disabled return sentinel values), and OCC is unconditionally enabled. TransportBulkAction checks only the target index setting when allowing writes with explicit IDs to backing indices.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
19 tasks
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
Compilation is broken by something else, updating the branch again... |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
Thanks Alan and Tanguy! |
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
…r index (elastic#144309) Replace the BulkByScrollOCCResolver, which rejected mixed disable_sequence_numbers settings across indices, with per-index handling. The search phase now always requests seqNoAndPrimaryTerm (indices with sequence numbers disabled return sentinel values), and OCC is unconditionally enabled. TransportBulkAction checks only the target index setting when allowing writes with explicit ids to backing indices. Relates elastic#136305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the BulkByScrollOCCResolver, which rejected mixed
disable_sequence_numbers settings across indices, with
per-index handling. The search phase now always requests
seqNoAndPrimaryTerm (indices with sequence numbers
disabled return sentinel values), and OCC is unconditionally enabled.
TransportBulkAction checks only the target index setting when
allowing writes with explicit ids to backing indices.
Relates #136305