ESQL: Remove duplicates and cleanup golden test orphans#144306
Merged
GalLalouche merged 7 commits intoelastic:mainfrom Mar 17, 2026
Merged
ESQL: Remove duplicates and cleanup golden test orphans#144306GalLalouche merged 7 commits intoelastic:mainfrom
GalLalouche merged 7 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
approved these changes
Mar 16, 2026
alex-spies
reviewed
Mar 16, 2026
...in/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerUnmappedGoldenTests.java
Show resolved
Hide resolved
alex-spies
approved these changes
Mar 16, 2026
Contributor
alex-spies
left a comment
There was a problem hiding this comment.
LGTM except for my comment above :)
Thanks @GalLalouche !
...in/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerUnmappedGoldenTests.java
Show resolved
Hide resolved
alex-spies
reviewed
Mar 16, 2026
...in/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerUnmappedGoldenTests.java
Show resolved
Hide resolved
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
Cleans up a few small issues introduced in elastic#143522. * Remove orphan tests. This unfortunately has to be done manually (though there is a draft for doing this automatically at some point ESQL: Remove orphan golden tests elastic#144305). * Remove duplicated test queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up a few small issues introduced in #143522.