ESQL: Skip missing test checker on release builds#144141
Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom Mar 12, 2026
Merged
ESQL: Skip missing test checker on release builds#144141elasticsearchmachine merged 1 commit intoelastic:mainfrom
elasticsearchmachine merged 1 commit intoelastic:mainfrom
Conversation
On release builds we get a smaller list of functions which makes the "missing test" checker angry. Some functions look fixed. But they aren't fixed. We could ignore this sort of failure in a complex way, but it isn't worth it. We just skip the test on release builds. It still does it's job - telling us about missing tests. Closes elastic#144076 Relates elastic#144086
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
6 tasks
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
On release builds we get a smaller list of functions which makes the "missing test" checker angry. Some functions look fixed. But they aren't fixed. We could ignore this sort of failure in a complex way, but it isn't worth it. We just skip the test on release builds. It still does it's job - telling us about missing tests. Closes elastic#144076 Relates elastic#144086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On release builds we get a smaller list of functions which makes the "missing test" checker angry. Some functions look fixed. But they aren't fixed. We could ignore this sort of failure in a complex way, but it isn't worth it. We just skip the test on release builds. It still does it's job - telling us about missing tests.
Closes #144076
Relates #144086