ESQL: Spot check telemetry features#144137
Merged
nik9000 merged 7 commits intoelastic:mainfrom Mar 20, 2026
Merged
Conversation
Switches the count-based tests for ESQL's telementry's `features` section from a `count` based test to a spot checked one - we test for the things we expect to be there. Also adds examples for how to run these tests - both to the `FeatureMetric` spot for features and to the scalar function writing guide at `scalar/package-info.java`. Relates to elastic#144086
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
6 tasks
luigidellaquila
approved these changes
Mar 13, 2026
Member
luigidellaquila
left a comment
There was a problem hiding this comment.
LGTM, thanks @nik9000!
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
Switches the count-based tests for ESQL's telementry's `features` section from a `count` based test to a spot checked one - we test for the things we expect to be there. Also adds examples for how to run these tests - both to the `FeatureMetric` spot for features and to the scalar function writing guide at `scalar/package-info.java`. Relates to elastic#144086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the count-based tests for ESQL's telementry's
featuressection from acountbased test to a spot checked one - we test for the things we expect to be there.Also adds examples for how to run these tests - both to the
FeatureMetricspot for features and to the scalar function writing guide atscalar/package-info.java.Relates to #144086