ESQL: Small nullify fix cleanups#143998
Merged
alex-spies merged 9 commits intoelastic:mainfrom Mar 12, 2026
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
| @Override | ||
| protected String maybeRandomizeQuery(String query) { | ||
| return randomlyNullify(query); | ||
| } |
Contributor
There was a problem hiding this comment.
Would this also require checking nullified fields capability in upgrade case?
Contributor
Author
There was a problem hiding this comment.
No, bwc tests are run with the mixed cluster and ccs test suites.
idegtiarenko
approved these changes
Mar 11, 2026
Contributor
Author
|
Thanks for the review @idegtiarenko ! |
Contributor
Author
|
CI reporting seems stuck, all checks are green on buildkite. Merging. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Mar 13, 2026
* Randomly nullify also in multi-node spec tests * Move child output removal into collectUnresolved * Add more reproducers (original reproducer also got fixed by another change) (cherry picked from commit 0af3229) # Conflicts: # x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerUnmappedTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2026
* Randomly nullify also in multi-node spec tests * Move child output removal into collectUnresolved * Add more reproducers (original reproducer also got fixed by another change) (cherry picked from commit 0af3229) # Conflicts: # x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerUnmappedTests.java
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
* Randomly nullify also in multi-node spec tests * Move child output removal into collectUnresolved * Add more reproducers (original reproducer also got fixed by another change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #142300, addressing the remaining comments and increasing test coverage.
In particular, the reproducer added in #142300 does not reproduce anymore because the new approach from #143399 avoids shadowing existing fields with
NULLaliases as long as aFROMcommand is used. This adds an analyzer test which usesROWand still reproduces the failure when #142300 gets reverted.