Skip to content

[DOCS] document replacement for search exists#14393

Merged
javanna merged 1 commit intoelastic:masterfrom
javanna:docs/search_exists
Nov 9, 2015
Merged

[DOCS] document replacement for search exists#14393
javanna merged 1 commit intoelastic:masterfrom
javanna:docs/search_exists

Conversation

@javanna
Copy link
Copy Markdown
Contributor

@javanna javanna commented Oct 30, 2015

Search exists api was removed from master and deprecated in 2.x. With this PR we document how the same can be achieved using the search api.

Relates to #13910

@javanna
Copy link
Copy Markdown
Contributor Author

javanna commented Oct 30, 2015

@clintongormley can you have a look please? also, I am not sure where this new section should go, probably not where I added it :)

jpountz
jpountz reviewed Oct 30, 2015
View reviewed changes
docs/reference/search/search.asciidoc Outdated
Copy link
Copy Markdown
Contributor

@jpountz jpountz Oct 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm being captain Obvious, but it could be worth just saying that a total hit count equal to 0 means that there are no matches, while a count greater than 0 means that there are matches?

@javanna javanna force-pushed the docs/search_exists branch from 7c20db0 to b1201fc Compare October 31, 2015 08:15
@javanna
Copy link
Copy Markdown
Contributor Author

javanna commented Oct 31, 2015

@jpountz pushed a new commit, thanks for having a look.

@javanna javanna mentioned this pull request Oct 31, 2015
Closed
clintongormley
clintongormley reviewed Nov 8, 2015
View reviewed changes
docs/reference/search/search.asciidoc Outdated
Copy link
Copy Markdown
Contributor

@clintongormley clintongormley Nov 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any hitS

@clintongormley
Copy link
Copy Markdown
Contributor

clintongormley commented Nov 8, 2015

Yeah, its current position feels too important. How about adding a section called terminate_after in the request body section, and putting the docs on there (along with the docs for terminate after that are currently on https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-body.html)

@javanna javanna force-pushed the docs/search_exists branch from b1201fc to a17221a Compare November 9, 2015 13:21
@javanna
Copy link
Copy Markdown
Contributor Author

javanna commented Nov 9, 2015

@clintongormley I pushed a new commit, can you double check please?

@clintongormley
Copy link
Copy Markdown
Contributor

clintongormley commented Nov 9, 2015

LGTM

@javanna javanna force-pushed the docs/search_exists branch from a17221a to ca980b7 Compare November 9, 2015 14:05
@javanna javanna merged commit ca980b7 into elastic:master Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@clintongormley clintongormley

Labels

>docs General docs changes v2.1.0 v2.2.0 v5.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javanna @clintongormley @jpountz