ESQL: Fix an issue with Lookup Join and loading Large Text Fields#143627
Merged
julian-elastic merged 1 commit intoelastic:mainfrom Mar 5, 2026
Merged
ESQL: Fix an issue with Lookup Join and loading Large Text Fields#143627julian-elastic merged 1 commit intoelastic:mainfrom
julian-elastic merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
@nik9000 This was copied from the non-streaming version here I did not fix this in the non-streaming version on purpose. It seems to me there is no point fixing the non-streaming version, because even if we split the page into multiple smaller pages all pages will be sent together in the Lookup Response, so there are actually no memory savings of splitting to multiple pages. Do you agree? |
fang-xing-esql
approved these changes
Mar 5, 2026
Member
fang-xing-esql
left a comment
There was a problem hiding this comment.
LGTM, thanks @julian-elastic !
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 5, 2026
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Mar 6, 2026
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue with Lookup Join and loading Large Text Fields.
Now we will split one page into potentially multiple pages in the ValuesFromSingleReader, resulting in no more CircuitBreaker exceptions in the Streaming path.
Closes #138510