Skip to content

Forward-port vector dotted field fix test features#143541

Merged
mayya-sharipova merged 3 commits intoelastic:mainfrom
mayya-sharipova:dynamic-udpate-dense-vector-9.4
Mar 4, 2026
Merged

Forward-port vector dotted field fix test features#143541
mayya-sharipova merged 3 commits intoelastic:mainfrom
mayya-sharipova:dynamic-udpate-dense-vector-9.4

Conversation

@mayya-sharipova
Copy link
Copy Markdown
Contributor

@mayya-sharipova mayya-sharipova commented Mar 4, 2026

PR #143421 introduced test features
mapper.dense_vector.dynamic_template_dotted_field_fix and
mapper.rank_vectors.dynamic_template_dotted_field_fix on the
9.3 branch. The underlying bug was already fixed on 9.4 by
PR #142754, so these feature declarations were never added here.

During rolling upgrades test from 9.3 to 9.4 the feature barrier
in NodeJoinExecutor rejects the 9.4 node:

Node is missing required features
[mapper.dense_vector.dynamic_template_dotted_field_fix,
mapper.rank_vectors.dynamic_template_dotted_field_fix]

This PR declares the same NodeFeatures in 9.4 and add
the corresponding YAML regression tests.

PR elastic#143421 introduced test features
mapper.dense_vector.dynamic_template_dotted_field_fix and
mapper.rank_vectors.dynamic_template_dotted_field_fix on the
9.3 branch. The underlying bug was already fixed on 9.4 by

During rolling upgrades test from 9.3 to 9.4 the feature barrier
in NodeJoinExecutor rejects the 9.4 node:

  Node is missing required features
  [mapper.dense_vector.dynamic_template_dotted_field_fix,
   mapper.rank_vectors.dynamic_template_dotted_field_fix]

This PR declares the same NodeFeatures in 9.4 and add the
corresponding YAML regression tests.
@mayya-sharipova mayya-sharipova added :Search Relevance/Vectors Vector search v9.4.0 backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Mar 4, 2026
@mayya-sharipova
Copy link
Copy Markdown
Contributor Author

Serverless check fails with:

ServerlessXpackRestIT > test > test {yaml=rank_vectors/rank_vectors/Rank vectors dynamic template with dotted field name and intermediate object} FAILED
--
java.lang.AssertionError: org.junit.internal.runners.model.MultipleFailureException: There were 3 errors:
java.lang.AssertionError(expected [2xx] status code but api [indices.put_template] returned [410 Gone] [{"error":{"root_cause":[{"type":"api_not_available_exception","reason":"uri [/_template/rank-vectors-dotted-template?error_trace=true] with method [PUT] exists but is not available when running in serverless mode","stack_trace":"org.elasticsearch.rest.ApiNotAvailableException: uri [/_template/rank-vectors-dotted-template?error_trace=true] with method [PUT] exists but is not available when running in serverless mode\n\tat org.elasticsearch.server@9.4.0-SNAPSHOT/org.elasticsearch.rest.RestController.handleServerlessRequestToProtectedResource(RestController.java:757)\n\tat org.elasticsearch.server@9.4.0-

will remove test for now to unblock BWC.

@mayya-sharipova
Copy link
Copy Markdown
Contributor Author

Serverless test fails on unrelated reasons, but given that this is blocker for other PR, I will merge it

@mayya-sharipova mayya-sharipova enabled auto-merge (squash) March 4, 2026 13:30
@mayya-sharipova mayya-sharipova disabled auto-merge March 4, 2026 13:30
@mayya-sharipova mayya-sharipova merged commit 3d65e95 into elastic:main Mar 4, 2026
34 of 35 checks passed
@mayya-sharipova mayya-sharipova deleted the dynamic-udpate-dense-vector-9.4 branch March 4, 2026 13:31
burqen pushed a commit to burqen/elasticsearch that referenced this pull request Mar 5, 2026
PR elastic#143421 introduced test features
mapper.dense_vector.dynamic_template_dotted_field_fix and
mapper.rank_vectors.dynamic_template_dotted_field_fix on the
9.3 branch. The underlying bug was already fixed on 9.4 by

During rolling upgrades test from 9.3 to 9.4 the feature barrier
in NodeJoinExecutor rejects the 9.4 node:

  Node is missing required features
  [mapper.dense_vector.dynamic_template_dotted_field_fix,
   mapper.rank_vectors.dynamic_template_dotted_field_fix]

This PR declares the same NodeFeatures in 9.4 and add the
corresponding YAML regression tests.

* Remove YAML tests for vector dotted field fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Search Relevance/Vectors Vector search v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant