Flattened field root blockloader tests: only apply null_value in some cases#143521
Merged
jordan-powers merged 4 commits intoelastic:mainfrom Mar 4, 2026
Merged
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
nik9000
approved these changes
Mar 3, 2026
…-root-block-loader-tests
…-root-block-loader-tests
burqen
pushed a commit
to burqen/elasticsearch
that referenced
this pull request
Mar 5, 2026
… cases (elastic#143521) The flattened field root block loader returns a json blob of the contents of the flattened field. Similar to synthetic_source, the blockloader will replace null in the returned json with the configured null_value only when loading from doc values.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 5, 2026
… cases (elastic#143521) The flattened field root block loader returns a json blob of the contents of the flattened field. Similar to synthetic_source, the blockloader will replace null in the returned json with the configured null_value only when loading from doc values.
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Mar 6, 2026
… cases (elastic#143521) The flattened field root block loader returns a json blob of the contents of the flattened field. Similar to synthetic_source, the blockloader will replace null in the returned json with the configured null_value only when loading from doc values.
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flattened field root block loader returns a json blob of the contents of the flattened field. Similar to synthetic_source, the blockloader will replace
nullin the returned json with the configurednull_valueonly when loading from doc values.Fixes #143412
Fixes #143413
Fixes #143414
Fixes #143514