Skip to content

Tests: StoreDirectoryMetricsIT.testDirectoryMetrics#143447

Merged
spinscale merged 4 commits intoelastic:mainfrom
spinscale:fix-143419
Mar 19, 2026
Merged

Tests: StoreDirectoryMetricsIT.testDirectoryMetrics#143447
spinscale merged 4 commits intoelastic:mainfrom
spinscale:fix-143419

Conversation

@spinscale
Copy link
Copy Markdown
Contributor

In order to not trigger any accidental background flushes, that may delete segment files, force merging down to a single segment before accessing the directory will prevent any changes to the directory in the background.

Closes #143419

@spinscale spinscale added >test-failure Triaged test failures from CI Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations v9.4.0 labels Mar 3, 2026
@elasticsearchmachine elasticsearchmachine added the needs:risk Requires assignment of a risk label (low, medium, blocker) label Mar 3, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Copy Markdown
Contributor

@drempapis drempapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spinscale spinscale force-pushed the fix-143419 branch 7 times, most recently from 7d47878 to 1120cab Compare March 16, 2026 10:12
@spinscale spinscale force-pushed the fix-143419 branch 2 times, most recently from b2b9354 to 94a047a Compare March 18, 2026 11:58
In order to not trigger any accidental background flushes, that may delete
segment files, force merging down to a single segment before accessing the
directory will prevent any changes to the directory in the background.

Closes elastic#143419
@spinscale spinscale merged commit 12fd013 into elastic:main Mar 19, 2026
36 checks passed
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Tests: Fix StoreDirectoryMetricsIT.testDirectoryMetrics

In order to not trigger any accidental background flushes, that may delete
segment files, force merging down to a single segment before accessing the
directory will prevent any changes to the directory in the background in the
test.

Closes elastic#143419

* improve message

* fix muted tests file

* remove accidentally readded muted test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:risk Requires assignment of a risk label (low, medium, blocker) :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] StoreDirectoryMetricsIT testDirectoryMetrics failing

3 participants