ESQL: Bridge Connector SPI to ExternalSplit#143331
Merged
costin merged 6 commits intoelastic:mainfrom Mar 1, 2026
Merged
Conversation
The Connector SPI used a local Split interface while the distribution infrastructure used ExternalSplit (NamedWriteable). This adds an execute(QueryRequest, ExternalSplit) overload to Connector that delegates to the legacy Split path by default, letting connectors opt-in to distributed split execution without breaking existing ones. - Connector: added default execute(QueryRequest, ExternalSplit) - AsyncConnectorSourceOperatorFactory: routes ExternalSplits from the slice queue to the new overload - FlightConnector: overrides the new method to use FlightSplit tickets - FlightSplit: NamedWriteable ExternalSplit for Flight endpoints with ticket size guard (16 KB max) - FlightSplitProvider: discovers splits via Flight getInfo() - FlightConnectorFactory: wires FlightSplitProvider - GrpcDataSourcePlugin: registers FlightSplit in NamedWriteableRegistry Relates elastic#143327 Developed using AI-assisted tooling
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @costin, I've created a changelog YAML for you. |
Replace server.close() with server.shutdown() + awaitTermination() to ensure the gRPC Netty event loop completes before the test framework's static state check runs. The previous close() could leave Netty's NettyServerHandler with in-flight operations that triggered spurious "An exception was thrown" warnings. Developed using AI-assisted tooling
bpintea
approved these changes
Mar 1, 2026
3 tasks
tballison
pushed a commit
to tballison/elasticsearch
that referenced
this pull request
Mar 3, 2026
The Connector SPI used a local `Split` interface while the distribution infrastructure used `ExternalSplit` (`NamedWriteable`). This adds an `execute(QueryRequest, ExternalSplit)` overload to `Connector` that delegates to the legacy `Split` path by default, letting connectors opt-in to distributed split execution without breaking existing ones. Developed using AI-assisted tooling Relates elastic#143327
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Connector SPI used a local
Splitinterface while the distributioninfrastructure used
ExternalSplit(NamedWriteable). This adds anexecute(QueryRequest, ExternalSplit)overload toConnectorthatdelegates to the legacy
Splitpath by default, letting connectorsopt-in to distributed split execution without breaking existing ones.
Developed using AI-assisted tooling
Relates #143327