Make DataType and DataFormat top-level enums#143312
Merged
Mikep86 merged 4 commits intoelastic:mainfrom Mar 2, 2026
Merged
Conversation
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
DonalEvans
approved these changes
Feb 27, 2026
timgrein
reviewed
Mar 2, 2026
| */ | ||
| public enum DataType { | ||
| TEXT(DataFormat.TEXT, EnumSet.of(DataFormat.TEXT)), | ||
| IMAGE(DataFormat.BASE64, EnumSet.of(DataFormat.BASE64)); |
Contributor
There was a problem hiding this comment.
The jina-clip-v2 API on Jina's side also allows to send a link for an image, so it doesn't need to be the image encoded as base64. It does in-fact work when specifying the format as base64 as I don't think we do any validation/enforcement?
Should we add a new format url or add text as valid format for the image data type? cc @DonalEvans
Contributor
Author
There was a problem hiding this comment.
Let's save that work for a follow-up PR. Adding a new format goes beyond the scope of refactoring.
timgrein
approved these changes
Mar 2, 2026
Contributor
timgrein
left a comment
There was a problem hiding this comment.
Adding the url data format is probably out-of-scope for this PR, just wanted to get the discussion started :)
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 2, 2026
…cations * upstream/main: (60 commits) Use batches for other bulk vector benchmarks (elastic#143167) Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:lookup-join.MvJoinKeyOnTheLookupIndexAfterStats} elastic#143388 Mute org.elasticsearch.snapshots.ConcurrentSnapshotsIT testBackToBackQueuedDeletes elastic#143387 [Inference API] Parse endpoint metadata from persisted endpoints (elastic#143081) Add cluster formation doc to DistributedArchitectureGuide (elastic#143318) Fix flattened root block loader null expectation (elastic#143238) Unmute ValueSourceReaderTypeConversionTests testLoadAll (elastic#143189) ESQL: Add split coalescing for many small files (elastic#143335) Unmute mixed-cluster spatial parse warning test (elastic#143186) Fix zero-size estimate in BytesRefBlock null test (elastic#143258) Make DataType and DataFormat top-level enums (elastic#143312) Add support for steps to change the target index name for later steps (elastic#142955) Set mayContainDuplicates flag to test deduplication (elastic#143375) ESQL: Fix Driver search load millis as nanos bug (elastic#143267) Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:lookup-join.LookupJoinWithMixPushableAndUnpushableFilters} elastic#143378 ESQL: Forbid MV_EXPAND before full text functions (elastic#143249) ESQL: Fix unresolved name pattern (elastic#143210) Implement boxplot queryDSL aggregation for exponential_histograms (elastic#143026) Add prefetching to x64 bulk vector implementations (elastic#142387) Make large segment vector tests resilient to memory constraints (elastic#143366) ...
tballison
pushed a commit
to tballison/elasticsearch
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
DataTypeandDataFormatto make them top-level enums. Also store the supported format set inDataTypeso that logic is centralized in the enum.These enums will be used in the
embeddingquery vector builder I am currently working on and it is more appropriate to refer to them as top-level enums.