Add extra info to debug an unexpected warning in tests#143217
Merged
elasticsearchmachine merged 6 commits intoelastic:mainfrom Mar 2, 2026
Merged
Add extra info to debug an unexpected warning in tests#143217elasticsearchmachine merged 6 commits intoelastic:mainfrom
elasticsearchmachine merged 6 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
limotova
approved these changes
Feb 27, 2026
tballison
pushed a commit
to tballison/elasticsearch
that referenced
this pull request
Mar 3, 2026
In elastic#141877, we deprecated the `default_metric` of an `aggregate_metric_double`. However, the following tests (elastic#142544, elastic#142964, elastic#142410 & elastic#142477) seem to encounter this warning even if they are not expected to set the `default_metric`. In this PR, we did the following: - For elastic#142544, we added the api group information in the warning failure exception, so that a yaml test will not only log the warning but it will also share more info about the api call. - For the other two, we catch the exception in `FieldExtractorTestCase` and log the mapping of the index, we hope that this can help us trace if there was a template used or not. - We also unmute the test because we cannot reproduce them locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #141877, we deprecated the
default_metricof anaggregate_metric_double. However, the following tests (#142544, #142964, #142410 & #142477) seem to encounter this warning even if they are not expected to set thedefault_metric.In this PR, we did the following:
FieldExtractorTestCaseand log the mapping of the index, we hope that this can help us trace if there was a template used or not.