Stabilize BatchDriver single-batch test startup#143188
Merged
MattAlp merged 5 commits intoelastic:mainfrom Mar 2, 2026
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Run the initial feedBatch call directly in the feeder thread so the test no longer races driver scheduling on the same SEARCH executor. Unmute the test now that startup batch feeding is deterministic. Made-with: Cursor
234005a to
55c559a
Compare
nik9000
approved these changes
Feb 27, 2026
MattAlp
commented
Mar 2, 2026
Removed muted test for MixedClusterEsqlSpecIT due to issue resolution.
tballison
pushed a commit
to tballison/elasticsearch
that referenced
this pull request
Mar 3, 2026
Run the initial feedBatch call directly in the feeder thread so the test no longer races driver scheduling on the same SEARCH executor. Unmute the test now that startup batch feeding is deterministic.
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes
BatchDriverTests.testSinglePageSingleBatchstartup ordering.Depends on #143258 (test harness fix on
main):BasicBlockTests.testBytesRefBlockBuilderWithNullszero-position builder estimate edge caseCloses: #142895