apm-data: explicit map of timestamp.us to long#143173
apm-data: explicit map of timestamp.us to long#143173endorama merged 12 commits intoelastic:mainfrom
Conversation
Add known issue for elastic/elasticsearch#143173 and elastic#20496
|
I tested 2 different paths for this fix:
The setup was APM Server => Logstash => Elasticsearch, to trigger the bug. What we want is for Checking the type of Using the development build with this fixAn example Java application sending a single trace on requests to Running the development build, we can see that the type has changed to Upgrading from
|
…arch output is used (#20508) * Known issue - timestamp.us as float Add known issue for elastic/elasticsearch#143173 and #20496 * Apply suggestion from @lucabelluccini * Apply suggestion from @lucabelluccini * Apply suggestion from @lucabelluccini
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @endorama, I've created a changelog YAML for you. |
carsonip
left a comment
There was a problem hiding this comment.
code change lgtm, 1 nit on test
x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/10_apm.yml
Show resolved
Hide resolved
x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/10_apm.yml
Outdated
Show resolved
Hide resolved
x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/10_apm.yml
Outdated
Show resolved
Hide resolved
x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/10_apm.yml
Show resolved
Hide resolved
x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/10_apm.yml
Outdated
Show resolved
Hide resolved
x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/10_apm.yml
Outdated
Show resolved
Hide resolved
|
part-2 checks are successful: https://buildkite.com/elastic/elasticsearch-pull-request/builds/124971/steps/canvas?sid=019cb3a4-e794-480c-9a62-3750dc7c7187&tab=output The failures looks unrelated to current changes. Updating main. |
💔 Backport failedYou can use sqren/backport to manually backport by running |
* add test to verify timestamp.us mapping and timestamp.us coercion behavior * explicitly map timestamp.us to long * apm-data: bump resource version
…locations * upstream/main: (51 commits) ESQL: Remaining serialization tests (elastic#143470) Eagerly release resources in `TransportAwaitClusterStateVersionAppliedAction` (elastic#143477) Stop and relocate sliced reindex on shutdown (elastic#143183) Documentation for query_vector base64 parameter (elastic#142675) ES|QL: Fix LIMIT after all columns are dropped (elastic#143463) Update docs-build.yml (elastic#142958) Fix KnnIndexTester to work with byte vectors (elastic#143493) Fix IndexInputUtils.withSlice to produce native-safe MemorySegments on Java 21 (elastic#143479) CPS fix: include only relevant projects in the search response metadata (elastic#143367) apm-data: explicit map of timestamp.us to long (elastic#143173) [Inference API] Add custom headers for Azure OpenAI Service (elastic#142969) ESQL: Add name IDs to golden tests and fix synthetic names (elastic#143450) Add getUnavailableShards to BaseBroadcastResponse (elastic#143406) Add description to reindex API without sensitive info (elastic#143112) SQL: fix CLI tests (elastic#143451) ES|QL: Add note of future removal of FORK implicit LIMIT (elastic#143457) [Test] Randomly disable doc values skippers in time-series indices (elastic#143389) Improve pattern text downgrade license test (elastic#143102) [Transform] Stop transforms at the end of tests (elastic#139783) Mute org.elasticsearch.compute.lucene.read.ValueSourceReaderTypeConversionTests testLoadAll elastic#143471 ...
* add test to verify timestamp.us mapping and timestamp.us coercion behavior * explicitly map timestamp.us to long * apm-data: bump resource version
* add test to verify timestamp.us mapping and timestamp.us coercion behavior * explicitly map timestamp.us to long * apm-data: bump resource version (cherry picked from commit 9b887f1)
* add test to verify timestamp.us mapping and timestamp.us coercion behavior * explicitly map timestamp.us to long * apm-data: bump resource version (cherry picked from commit 9b887f1)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* add test to verify timestamp.us mapping and timestamp.us coercion behavior * explicitly map timestamp.us to long * apm-data: bump resource version (cherry picked from commit 9b887f1) # Conflicts: # x-pack/plugin/apm-data/src/main/resources/resources.yaml
* add test to verify timestamp.us mapping and timestamp.us coercion behavior * explicitly map timestamp.us to long * apm-data: bump resource version (cherry picked from commit 9b887f1) # Conflicts: # x-pack/plugin/apm-data/src/main/resources/resources.yaml
We recently discovered a bug related to a missing mapping: elastic/apm-server#20496
This PR fixes it by adding the proper mapping in template for field
timestamp.uson traces data streams.Bumped resource version to ensure upgrade path works too.
Closes elastic/apm-server#20496
We would like to backport this fix to
8.19,9.29.3, but I'm not sure how to trigger the automation.