Skip to content

Ensure log4j plugins are enabled for various benchmarks#143041

Merged
thecoop merged 1 commit intoelastic:mainfrom
thecoop:benchmark-logging-reg
Feb 25, 2026
Merged

Ensure log4j plugins are enabled for various benchmarks#143041
thecoop merged 1 commit intoelastic:mainfrom
thecoop:benchmark-logging-reg

Conversation

@thecoop
Copy link
Copy Markdown
Member

@thecoop thecoop commented Feb 25, 2026

Benchmarks can sometimes try to use logging, which causes an exception during the benchmark run. Make sure plugins are enabled, and the node_name has a value so the exception does not happen

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search labels Feb 25, 2026
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.4.0 labels Feb 25, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Copy Markdown
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thecoop

@thecoop thecoop merged commit 495c375 into elastic:main Feb 25, 2026
35 checks passed
@thecoop thecoop deleted the benchmark-logging-reg branch February 25, 2026 12:56
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Feb 25, 2026
ldematte pushed a commit that referenced this pull request Feb 27, 2026
Follow on from #143041 - put logging config in a shared method. Setting the machine name needs to be after the plugin setup
tballison pushed a commit to tballison/elasticsearch that referenced this pull request Mar 3, 2026
Follow on from elastic#143041 - put logging config in a shared method. Setting the machine name needs to be after the plugin setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants