Fix TSDBSyntheticIdUpgradeIT exception assertion#142849
Merged
burqen merged 1 commit intoelastic:mainfrom Feb 23, 2026
Merged
Conversation
When creating an index with ESRestTestCase.createIndex a random xContentType will be used. If the type is YAML, the exception message will be split into multiple lines if the lines are long. This will break the format of the expected string and the test fails. This is fixed by getting the actual Response object from the exception and evaluate error.reason which will give the original exception message without the line breaks.
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
sidosera
pushed a commit
to sidosera/elasticsearch
that referenced
this pull request
Feb 24, 2026
When creating an index with ESRestTestCase.createIndex a random xContentType will be used. If the type is YAML, the exception message will be split into multiple lines if the lines are long. This will break the format of the expected string and the test fails. This is fixed by getting the actual Response object from the exception and evaluate error.reason which will give the original exception message without the line breaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating an index with ESRestTestCase.createIndex a random xContentType will be used. If the type is YAML, the exception message will be split into multiple lines if the lines are long. This will break the format of the expected string and the test fails.
This is fixed by getting the actual Response object from the exception and evaluate error.reason which will give the original exception message without the line breaks.
Fix #141734, #141749