Add TimestampBoundsAware analysis mechanism by felixbarny · Pull Request #142750 · elastic/elasticsearch

felixbarny · 2026-02-20T11:24:54Z

Introduce timestamp-bounds-aware analysis plumbing and use it to inject filter-derived bounds into PromqlCommand range queries during analysis.

Refactors PromQL timestamp-bounds inference from a one-off instanceof PromqlCommand check in EsqlSession.execute() into a generic, extensible analysis mechanism:

New TimestampBoundsAware<T> marker interface for nodes (expressions or plans) that need @timestamp bounds from the query DSL filter
ResolveTimestampBoundsAware analyzer rule to inject bounds during analysis
checkUnresolvedTimestampBounds verifier check to reject expressions still missing bounds after analysis
PromqlCommand refactored to implement the new interface
AnalyzerContext extended to carry TimestampBounds
EsqlSession.analyzedPlan() extracts bounds from the request filter and passes them to the context

The next step for this is to make TBUCKET TimestampBoundsAware once #142747 is merged. This will allow simpler usage of it in Kibana, for example: TBUCKET(100) rather than TBUCKET(100, ?_tstart, ?_tend).

Introduce timestamp-bounds-aware analysis plumbing and use it to inject filter-derived bounds into PromqlCommand range queries during analysis.

elasticsearchmachine · 2026-02-20T11:25:20Z

Pinging @elastic/es-storage-engine (Team:StorageEngine)

kkrik-es · 2026-02-20T12:13:22Z

Before onboarding on this, let's get alignment on the syntax and the expected outcome. Mind putting together a single-pager and sharing with metrics program and esql? Such changes are far-reaching.

felixbarny · 2026-02-20T12:40:23Z

Makes sense. Note that this change in particular doesn't add any functional changes. It just adds a more generic mechanism how to get access to the TimestampBounds, replacing the explicit wiring for PromQL in EsqlSession.

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java

...sql/src/main/java/org/elasticsearch/xpack/esql/expression/function/TimestampBoundsAware.java

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java

…logical plans

fang-xing-esql

Thank you @felixbarny, the approach of TimestampBoundsAware looks reasonable to me, if we can have some negative tests that will be very helpful to walk through how it works.

We have a couple of interfaces like PostAnalysisVerificationAware and PostAnalysisPlanVerificationAware, I wonder how does TimestampBoundsAware work with them? A lot of times the verification of a plan or a function is inside the plan or the function itself, I wonder if we want to follow that convention. @bpintea designed a lot of these interfaces, perhaps wait for @bogdan to take a look, in case I overlooked anything.

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Verifier.java

felixbarny · 2026-03-06T08:22:15Z

We have a couple of interfaces like PostAnalysisVerificationAware and PostAnalysisPlanVerificationAware, I wonder how does TimestampBoundsAware work with them? A lot of times the verification of a plan or a function is inside the plan or the function itself, I wonder if we want to follow that convention. @bpintea designed a lot of these interfaces, perhaps wait for @bogdan to take a look, in case I overlooked anything.

Good catch. My initial idea was that LogicalPlans would validate this via PostAnalysisVerificationAware#postAnalysisVerification but that we'd validate this for TimestampBoundsAware.OfExpression generically in the verifier. This was based on the wrong assumption that Expressions can't be PostAnalysisVerificationAware. Let me change it so that all implementations of TimestampBoundsAware are responsible for validating themselves.

…dation

coderabbitai · 2026-03-06T08:32:52Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)

Team:Delivery
Team:Search - Inference

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: d545db5e-071a-4bd9-9be4-2be70575a0e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

felixbarny · 2026-03-06T08:36:05Z

@coderabbitai review

coderabbitai · 2026-03-06T08:36:16Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

fang-xing-esql

LGTM, thank you @felixbarny !

bpintea

Didn't do a deep review, but conceptually LGTM.

Introduce timestamp-bounds-aware analysis plumbing and use it to inject filter-derived bounds into PromqlCommand range queries during analysis.

Add TimestampBoundsAware analysis mechanism

0c58bf7

Introduce timestamp-bounds-aware analysis plumbing and use it to inject filter-derived bounds into PromqlCommand range queries during analysis.

felixbarny requested review from dnhatn and kkrik-es February 20, 2026 11:24

felixbarny self-assigned this Feb 20, 2026

felixbarny added the :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL label Feb 20, 2026

elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team Team:StorageEngine v9.4.0 labels Feb 20, 2026

felixbarny added 2 commits February 20, 2026 12:26

Merge remote-tracking branch 'origin/main' into timestamp-bounds-aware

ca192e3

Fix post merge compile error

8f4eb61

felixbarny added the >non-issue label Feb 20, 2026

[CI] Auto commit changes from spotless

6c3ddd9

felixbarny mentioned this pull request Feb 20, 2026

Support target bucket count in TBUCKET with explicit from/to date range #142747

Merged

felixbarny added 2 commits February 20, 2026 13:56

Fix compile error

2fb27a8

Add test to ignore should matchers

6d04e78

sidosera reviewed Mar 2, 2026

View reviewed changes

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java Outdated Show resolved Hide resolved

sidosera reviewed Mar 2, 2026

View reviewed changes

...sql/src/main/java/org/elasticsearch/xpack/esql/expression/function/TimestampBoundsAware.java Show resolved Hide resolved

sidosera reviewed Mar 2, 2026

View reviewed changes

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java Show resolved Hide resolved

sidosera approved these changes Mar 2, 2026

View reviewed changes

felixbarny added 2 commits March 2, 2026 14:33

Merge remote-tracking branch 'origin/main' into timestamp-bounds-aware

0213b87

Avoid unchecked casts by creating sub-interfaces for expressions and …

41b6c3d

…logical plans

felixbarny requested review from bpintea and fang-xing-esql March 3, 2026 15:06

fang-xing-esql reviewed Mar 5, 2026

View reviewed changes

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Verifier.java Outdated Show resolved Hide resolved

felixbarny added 2 commits March 6, 2026 09:25

Merge remote-tracking branch 'origin/main' into timestamp-bounds-aware

13f44a9

Make implementations of TimestampBoundsAware responsible for the vali…

2077837

…dation

[CI] Auto commit changes from spotless

ebb5b1f

felixbarny requested a review from fang-xing-esql March 9, 2026 09:35

felixbarny and others added 3 commits March 11, 2026 10:26

Merge remote-tracking branch 'origin/main' into timestamp-bounds-aware

723a7f8

Merge branch 'main' into timestamp-bounds-aware

42e92aa

Merge branch 'main' into timestamp-bounds-aware

ccddd33

fang-xing-esql approved these changes Mar 11, 2026

View reviewed changes

bpintea approved these changes Mar 11, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into timestamp-bounds-aware

8ad8b93

felixbarny enabled auto-merge (squash) March 11, 2026 14:50

elasticsearchmachine and others added 2 commits March 11, 2026 14:58

[CI] Auto commit changes from spotless

f2c5424

Merge branch 'main' into timestamp-bounds-aware

9c57e2e

felixbarny merged commit 99185b1 into elastic:main Mar 11, 2026
35 of 36 checks passed

Conversation

felixbarny commented Feb 20, 2026

Uh oh!

elasticsearchmachine commented Feb 20, 2026

Uh oh!

kkrik-es commented Feb 20, 2026

Uh oh!

felixbarny commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fang-xing-esql left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

felixbarny commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

felixbarny commented Mar 6, 2026

Uh oh!

coderabbitai bot commented Mar 6, 2026

Uh oh!

fang-xing-esql left a comment

Choose a reason for hiding this comment

Uh oh!

bpintea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

felixbarny commented Feb 20, 2026 •

edited

Loading

felixbarny commented Mar 6, 2026 •

edited

Loading

coderabbitai bot commented Mar 6, 2026 •

edited

Loading